removed checks that keep giving false positives. #10796
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The purpose of this PR is to remove rules which are known to cause false positives. These rules are propagated to tools like the prometheus-operator which have tools like alertmanager which will continuously emit alerts even when the etcd cluster is in a healthy state with no rpc errors.
|
Related issue: openshift/cluster-monitoring-operator#248. The issue in this project: #10289. I think it should be fixed and we should not disable monitoring. |
|
@paskal we should unblock actual customers that are experiencing these issues. Yes they should be fixed, until then there are tools like prometheus-operator that currently rely on this repo for the source of truth. These can be added again on a later date. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to remove rules which are known to cause false positives. These rules are propagated to tools like the prometheus-operator which have tools like alertmanager which will continuously emit alerts even when the etcd cluster is in a healthy state with no rpc errors.
I suggest that when the underlying issues are found, we can add them here again, however, at the moment these have to be manually removed.